From 4556d0f0fe969e8f2144602696b4580b9718b71e Mon Sep 17 00:00:00 2001 From: Christoph Reiter Date: Tue, 26 Jul 2016 13:09:21 +0200 Subject: [PATCH] gtkbox: remove unnecessary queue_compute_expand() The expand child property does not have any effect on the expand state of the GtkBox, so queuing a compute_expand when changing it is not needed. https://bugzilla.gnome.org/show_bug.cgi?id=769162 --- gtk/gtkbox.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/gtk/gtkbox.c b/gtk/gtkbox.c index 93206cf403..e39eb495a5 100644 --- a/gtk/gtkbox.c +++ b/gtk/gtkbox.c @@ -2540,17 +2540,11 @@ gtk_box_set_child_packing (GtkBox *box, gtk_widget_freeze_child_notify (child); if (list) { - gboolean expanded; + expand = expand != FALSE; - expanded = expand != FALSE; - - /* avoid setting expand if unchanged, since queue_compute_expand - * can be expensive-ish - */ - if (child_info->expand != expanded) + if (child_info->expand != expand) { - child_info->expand = expand != FALSE; - gtk_widget_queue_compute_expand (GTK_WIDGET (box)); + child_info->expand = expand; gtk_container_child_notify_by_pspec (GTK_CONTAINER (box), child, child_props[CHILD_PROP_EXPAND]); } -- 2.30.2